[ci-scan] Skip DnsGetHost*_LocalhostSubdomain_RespectsAddressFamily on Android (refs #128253) - #128353
#128353Closed
github-actions[bot] wants to merge 2 commits into
maindotnet/runtime:mainfrom
ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72edotnet/runtime:ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72eCopy head branch name to clipboard
Closed
[ci-scan] Skip DnsGetHost*_LocalhostSubdomain_RespectsAddressFamily on Android (refs #128253)#128353github-actions[bot] wants to merge 2 commits intomaindotnet/runtime:mainfrom ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72edotnet/runtime:ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72eCopy head branch name to clipboard
github-actions[bot] wants to merge 2 commits into
maindotnet/runtime:mainfrom
ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72edotnet/runtime:ci-scan/disable-dns-localhost-subdomain-android-128253-c5b4bb84f6bda72eCopy head branch name to clipboard
Conversation
…(refs #128253) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced May 19, 2026
Open
rzikm
approved these changes
May 19, 2026
kotlarmilos
marked this pull request as ready for review
July 28, 2026 14:28
Member
|
@matouskozak Let's check if this PR is still needed |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses persistent Android CI failures in System.Net.NameResolution functional tests by marking the affected localhost-subdomain “respects AddressFamily” tests as skipped on Android.
Changes:
- Add an
[ActiveIssue]skip on Android forDnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily. - Add an
[ActiveIssue]skip on Android forDnsGetHostAddresses_LocalhostSubdomain_RespectsAddressFamily.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs | Adds an Android [ActiveIssue] skip attribute to the AddressFamily-respecting localhost-subdomain GetHostEntry test. |
| src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostAddressesTest.cs | Adds an Android [ActiveIssue] skip attribute to the AddressFamily-respecting localhost-subdomain GetHostAddresses test. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Comment on lines
415
to
419
| [Theory] | ||
| [InlineData(AddressFamily.InterNetwork)] | ||
| [InlineData(AddressFamily.InterNetworkV6)] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/128253", TestPlatforms.Android)] | ||
| public async Task DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily(AddressFamily addressFamily) |
Comment on lines
250
to
254
| [Theory] | ||
| [InlineData(AddressFamily.InterNetwork)] | ||
| [InlineData(AddressFamily.InterNetworkV6)] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/128253", TestPlatforms.Android)] | ||
| public async Task DnsGetHostAddresses_LocalhostSubdomain_RespectsAddressFamily(AddressFamily addressFamily) |
Member
I don't see it failing on the latest extra-platforms run https://dev.azure.com/dnceng-public/public/_build/results?buildId=1529233&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
The tests
DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamilyandDnsGetHostAddresses_LocalhostSubdomain_RespectsAddressFamilyfail on Android becauseDns.GetHostEntry/GetHostAddressesreturns IPv6 addresses when only IPv4 (InterNetwork) is requested. The Android resolver does not filter by address family for localhost subdomains. The[ActiveIssue]attribute is the narrowest correct fix — Android-only, matching the observed failure scope.Linked KBE: #128253
Match verification (from Step 4.8):
GetHostEntryTest.DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamilyand siblingGetHostAddressesvariantAssert.All() FailurewithExpected: InterNetwork, Actual: InterNetworkV6Impact on platforms
Errors log
First build it occurred
Linked issue
#128253
Note
🔒 Integrity filter blocked 1 item
The following item was blocked because it doesn't meet the GitHub integrity level.
search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: