Prioritize setTgtPref for the op1 use - #128333
#128333Closed
tannergooding wants to merge 2 commits into
Closed
Prioritize setTgtPref for the op1 use#128333tannergooding wants to merge 2 commits into
tannergooding wants to merge 2 commits into
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts CoreCLR JIT LSRA target-preference handling, aiming to make the first preferred operand dominate register selection and changing xarch select handling.
Changes:
- Reorders
setTgtPrefcalls inBuildDef. - Removes xarch
BuildSelectsuppression that previously ignored the false operand as a target preference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/coreclr/jit/lsraxarch.cpp |
Updates xarch select target-preference behavior. |
src/coreclr/jit/lsrabuild.cpp |
Changes target-preference application order during def construction. |
tannergooding
marked this pull request as draft
May 18, 2026 17:32
This was referenced May 18, 2026
Open
| @@ -967,13 +967,6 @@ int LinearScan::BuildSelect(GenTreeOp* select) | ||
| srcCount++; |
| @@ -967,13 +967,6 @@ int LinearScan::BuildSelect(GenTreeOp* select) | ||
| srcCount++; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking TP/CQ for a case that BuildSelect indicates produces much better codegen.