Fix typo in ifdef for Rune - #123359
#123359Merged
Merged
Fix typo in ifdef for Rune#123359
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in a preprocessor directive in Rune.cs. The constant name was misspelled as SYSTEM_PRIVATE_CORLIB instead of the correct SYSTEM_PRIVATE_CORELIB, which prevented the proper exception message from being used when building System.Private.CoreLib.
Changes:
- Corrected preprocessor directive spelling from
SYSTEM_PRIVATE_CORLIBtoSYSTEM_PRIVATE_CORELIB
tannergooding
approved these changes
Jan 19, 2026
tannergooding
enabled auto-merge (squash)
January 19, 2026 19:30
jkotas
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runehad a typo,SYSTEM_PRIVATE_CORLIBinstead ofSYSTEM_PRIVATE_CORELIB. This led to the very minor issue that the ArgumentException would not use the expected exception message.We don't typically unit test the text of exception messages, but if we want to do something we can.