Include host symbols in testhost folder - #122999
#122999Merged
elinor-fung merged 1 commit intoJan 8, 2026
dotnet:maindotnet/runtime:mainfrom
elinor-fung:testhost-host-symbolselinor-fung/runtime:testhost-host-symbolsCopy head branch name to clipboard
Merged
Include host symbols in testhost folder#122999elinor-fung merged 1 commit intodotnet:maindotnet/runtime:mainfrom elinor-fung:testhost-host-symbolselinor-fung/runtime:testhost-host-symbolsCopy head branch name to clipboard
elinor-fung merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:testhost-host-symbolselinor-fung/runtime:testhost-host-symbolsCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the build process to include symbol files (PDB files on Windows, .pdb/.dwarf on other platforms) for the host components (dotnet executable, hostfxr, and hostpolicy) when creating the testhost folder. The changes replace the previous single-path symbol file references with glob patterns that search both the main binary directory and a PDB subdirectory.
Key Changes:
- Replaced specific symbol file references with wildcard-based ItemGroups that search multiple directories
- Updated Copy tasks to include the new symbol ItemGroups alongside their respective host component binaries
- Modified Exists conditions from checking the entire ItemGroup to checking individual items with '%(Identity)'
hoyosjs
approved these changes
Jan 8, 2026
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy symbols for dotnet, hostfxr, and hostpolicy when creating the testhost folder.