Add a few EntityRegistry features in managed ilasm - #122957
#122957Merged
Merged
Add a few EntityRegistry features in managed ilasm#122957
Conversation
Implement several EntityRegistry.cs features for the C# ilasm replacement: - Add ClassLayout table emission: parse .pack and .size directives, emit AddTypeLayout for types with explicit packing or size - Add FieldLayout table emission: parse [offset] syntax on fields, emit AddFieldLayout for fields with explicit offsets - Add FieldRVA table emission: wire .data declarations to fields with 'at' syntax, emit AddFieldRelativeVirtualAddress - Implement GetPinnedType for pinned type signature encoding - Build full assembly-qualified names for type references with Version, Culture, and PublicKeyToken - Fix float32/float64 missing from VisitSimpleType switch - Fix core assembly resolution to match native ilasm: prefer System.Private.CoreLib, then System.Runtime, then mscorlib, then netstandard, with fallback to creating mscorlib reference. Also fix AssemblyRef table emission and dictionary key comparison. - Add tests for ClassLayout, FieldLayout, FieldRVA, and core assembly resolution functionality
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT |
jkoritzinsky
approved these changes
Jan 7, 2026
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
Looks good! Just one question.
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement several EntityRegistry.cs features for the C# ilasm replacement:
Add ClassLayout table emission: parse .pack and .size directives, emit AddTypeLayout for types with explicit packing or size
Add FieldLayout table emission: parse [offset] syntax on fields, emit AddFieldLayout for fields with explicit offsets
Add FieldRVA table emission: wire .data declarations to fields with 'at' syntax, emit AddFieldRelativeVirtualAddress
Implement GetPinnedType for pinned type signature encoding
Build full assembly-qualified names for type references with Version, Culture, and PublicKeyToken
Fix float32/float64 missing from VisitSimpleType switch
Fix core assembly resolution to match native ilasm: prefer System.Private.CoreLib, then System.Runtime, then mscorlib, then netstandard, with fallback to creating mscorlib reference. Also fix AssemblyRef table emission and dictionary key comparison.
Add tests for ClassLayout, FieldLayout, FieldRVA, and core assembly resolution functionality