Remove now obsolete POPFRAMES - #122905
#122905Merged
Merged
Conversation
After the change that removed FEATURE_EH_FUNCLETS, the POPFRAMES option is no longer used.
Member
Author
|
cc: @am11 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete POPFRAMES stackwalk option and all code guarded by STACKWALKER_MAY_POP_FRAMES preprocessor directives. These became obsolete after the removal of FEATURE_EH_FUNCLETS. The changes are purely code deletion with no functional impact on remaining code paths.
Key changes:
- Removed the
POPFRAMESconstant definition from the stackwalk flags - Removed all
STACKWALKER_MAY_POP_FRAMESconditional compilation blocks - Simplified control flow by removing POPFRAMES-specific if-else branches
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/threads.h | Removes the POPFRAMES constant definition (0x0004) from stackwalk flags |
| src/coreclr/vm/stackwalk.cpp | Removes all POPFRAMES-related assertions, conditional compilation blocks, and frame-popping logic; simplifies control flow to retain only the non-POPFRAMES code paths |
jkotas
reviewed
Jan 5, 2026
jkotas
approved these changes
Jan 5, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Member
|
/ba-g DeadLetter |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change that removed
FEATURE_EH_FUNCLETS, thePOPFRAMESstackwalk option is no longer used. Also all code underSTACKWALKER_MAY_POP_FRAMESifdef can be removed.