Use Array.Copy in Match.AddMatch - #122894
#122894Merged
Merged
Use Array.Copy in Match.AddMatch#122894
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves code quality by replacing a manual for-loop with the built-in Array.Copy method in the Match.AddMatch method. The change enhances both readability and performance by using a well-optimized framework method for copying array elements.
Key Changes:
- Replaced manual element-by-element array copy loop with
Array.Copycall inMatch.AddMatch
MihaZupan
approved these changes
Jan 5, 2026
stephentoub
enabled auto-merge (squash)
January 5, 2026 21:09
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.