Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix regression introduced by recent PR - #122850

#122850
Merged
jkotas merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
jkotas:fix-regressionjkotas/runtime:fix-regressionCopy head branch name to clipboard
Jan 5, 2026
Merged

Fix regression introduced by recent PR#122850
jkotas merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
jkotas:fix-regressionjkotas/runtime:fix-regressionCopy head branch name to clipboard

Conversation

@jkotas

@jkotas jkotas commented Jan 4, 2026

Copy link
Copy Markdown
Member

Relax assert condition

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas

jkotas commented Jan 4, 2026

Copy link
Copy Markdown
Member Author

Fixing test failures in outer loop, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1242629&view=ms.vss-test-web.build-test-results-tab&runId=34586056&paneView=debug&resultId=120695 : Assertion failed. elementType >= EETypeElementType.Boolean && elementType <= EETypeElementType.Double

@jkotas

jkotas commented Jan 4, 2026

Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relaxes an assertion condition in the GetNormalizedIntegralArrayElementType method to fix a regression. The assertion is changed from checking a specific range of valid element types to checking that the element type value is less than 32.

Key Changes

  • Replaced a range check assertion (elementType >= Boolean && elementType <= Double) with a bounds check ((int)elementType < 32)
  • Added a comment explaining that the shift operator uses only the low-order five bits of the right-hand operand

@jkotas

jkotas commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

/ba-g deadletter

@jkotas
jkotas merged commit 201e6c6 into dotnet:main Jan 5, 2026
121 of 129 checks passed
@jkotas
jkotas deleted the fix-regression branch January 5, 2026 07:09
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.