Update comment to use Ascii.IsValid in KeyAnalyzer - #122715
#122715Merged
eiriktsarpalis merged 2 commits intoJan 12, 2026
dotnet:maindotnet/runtime:mainfrom
prozolic:update-comments-keyanalyzerprozolic/runtime:update-comments-keyanalyzerCopy head branch name to clipboard
Merged
Update comment to use Ascii.IsValid in KeyAnalyzer#122715eiriktsarpalis merged 2 commits intodotnet:maindotnet/runtime:mainfrom prozolic:update-comments-keyanalyzerprozolic/runtime:update-comments-keyanalyzerCopy head branch name to clipboard
Ascii.IsValid in KeyAnalyzer#122715eiriktsarpalis merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
prozolic:update-comments-keyanalyzerprozolic/runtime:update-comments-keyanalyzerCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates comments in KeyAnalyzer.cs to reflect a previous code change from IsAllAscii to Ascii.IsValid that was made in PR #119673. The comments now accurately describe the actual method being used in the code.
- Updates outdated comment references from
IsAllAsciitoAscii.IsValid
Member
|
/ba-g unrelated test failures |
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update comment in KeyAnalyzer to reflect change from
IsAllAsciitoAscii.IsValidin #119673