[clr-interp] Fix some interop suite issues - #122656
#122656Merged
davidwrighton merged 5 commits intoJan 6, 2026
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_some_interop_suite_issuesdavidwrighton/runtime:fix_some_interop_suite_issuesCopy head branch name to clipboard
Merged
[clr-interp] Fix some interop suite issues#122656davidwrighton merged 5 commits intodotnet:maindotnet/runtime:mainfrom davidwrighton:fix_some_interop_suite_issuesdavidwrighton/runtime:fix_some_interop_suite_issuesCopy head branch name to clipboard
davidwrighton merged 5 commits into
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_some_interop_suite_issuesdavidwrighton/runtime:fix_some_interop_suite_issuesCopy head branch name to clipboard
Conversation
- The HasUnmanagedCallersOnlyAttribute api is... not as accurate as I'd like. See comment in the code
- Fix an issue with platform detection where we are attempting to test COM interop tests with the interpreter enabled - Fix an issue with creating a delegate to a method marked with an [UnmanagedCallersOnly] attribute. NOTE: This fix is probably not acceptable for long term usage as it injects a very expensive metadata lookup into the slow path delegate contruction logic.
Member
Author
|
@AaronRobinsonMSFT @jkoritzinsky do you have an opinion on the check of HasUnmanagedCallersOnlyAttribute in the delegate constructor. We currently have a check for it in optimized delegate construction, which is almost always used by the JIT, but I need to know if we really need that to work, or if it's just a convenience feature that it fails. |
Member
Author
|
/azp run runtime-interpreter |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Dec 19, 2025
…e_interop_suite_issues
Member
Author
|
/azp run runtime-interpreter |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 6, 2026
davidwrighton
marked this pull request as ready for review
January 6, 2026 18:08
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several interop suite issues related to the CoreCLR interpreter. The main changes include: (1) correcting platform detection for built-in COM support when the interpreter is active, and (2) implementing a peephole optimization for delegate constructor patterns to use optimized constructors.
Key changes:
- Modified
IsBuiltInComEnabledto return false when the CoreCLR interpreter is active - Added a peephole optimizer that recognizes
LDFTN/LDVIRTFTN+NEWOBJpatterns and rewrites them to use optimized delegate constructors - Refactored ldftn-related code into reusable helper methods
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| InvalidSafeHandleMarshallingTests.cs | Adds test skip attribute for interpreter mode with comment explaining COM interop behavior |
| PlatformDetection.cs | Modifies IsBuiltInComEnabled to exclude CoreCLR interpreter from COM support detection |
| compiler.h | Adds member variable m_pConstrainedToken and declares new helper methods for ldftn operations and delegate constructor optimization |
| compiler.cpp | Implements delegate constructor peephole optimization, refactors ldftn/ldvirtftn code into EmitLdftn, extracts EmitDup and EmitLoadPointer helpers, and converts constrained token handling from local to member variable |
Member
Author
|
/ba-g known issues + a machine that would have produced a known issue instead dead-lettered. |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several issues that were blocking the interop suite from passing: