Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update HybridGlobalization error messages to remove obsolete guidance - #122645

#122645
Merged
matouskozak merged 6 commits into
maindotnet/runtime:mainfrom
copilot/remove-hybrid-globalization-referencedotnet/runtime:copilot/remove-hybrid-globalization-referenceCopy head branch name to clipboard
Jan 5, 2026
Merged

Update HybridGlobalization error messages to remove obsolete guidance#122645
matouskozak merged 6 commits into
maindotnet/runtime:mainfrom
copilot/remove-hybrid-globalization-referencedotnet/runtime:copilot/remove-hybrid-globalization-referenceCopy head branch name to clipboard

Conversation

Copilot AI commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

main PR

Description

HybridGlobalization error messages in Strings.resx incorrectly told users to "Disable it to load larger ICU bundle" — but hybrid globalization can no longer be disabled on Apple mobile platforms.

Updated 6 error messages to:

  • Remove the obsolete "Disable it to load larger ICU bundle" guidance
  • Replace "when HybridGlobalization=true on this platform" with clearer "on Apple mobile platforms" wording

Affected messages:

  • PlatformNotSupported_HybridGlobalizationWithCompareOptions
  • PlatformNotSupported_HybridGlobalizationWithMixedCompositions
  • PlatformNotSupported_HybridGlobalizationWithCompareOptionsForCulture
  • PlatformNotSupported_HybridGlobalizationWithMatchLength
  • PlatformNotSupported_HybridGlobalization
  • PlatformNotSupportedWithReason_HybridGlobalization

Customer Impact

Users hitting these exceptions receive incorrect guidance suggesting a configuration option that no longer exists.

Regression

No. The guidance was always incorrect for these platforms; hybrid globalization was never disableable on Apple mobile.

Testing

  • Built libs successfully
  • Verified no remaining occurrences of obsolete text

Risk

Low. String-only change with no behavioral impact.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Updated 6 error messages in Strings.resx that incorrectly told users to
"Disable it to load larger ICU bundle" when HybridGlobalization=true.
Since hybrid globalization can no longer be disabled on Apple mobile
platforms, the messages now direct users to adjust their code or open
an issue on https://github.com/dotnet/runtime.

Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove hybrid globalization references from Strings.resx Update HybridGlobalization error messages to remove obsolete guidance Dec 18, 2025
Copilot AI requested a review from matouskozak December 18, 2025 17:10
Comment thread src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Outdated
… messages

Per review feedback, changed error messages to use clearer platform-specific
language "on Apple mobile platforms" instead of "when HybridGlobalization=true
on this platform".

Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates HybridGlobalization-related error messages in Strings.resx to reflect current platform constraints. The key change is removing guidance to disable HybridGlobalization (which is no longer possible on Apple mobile platforms) and directing users to adjust their code or report issues on GitHub instead.

  • Replaces obsolete "Disable it to load larger ICU bundle" guidance with actionable advice
  • Updates platform references from "when HybridGlobalization=true on this platform" to clearer "on Apple mobile platforms"
  • Directs users to https://github.com/dotnet/runtime for reporting issues

Comment thread src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Outdated
Comment thread src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Outdated
Comment thread src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Outdated
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Per review feedback, simplified error messages by removing the
"Adjust your code or open an issue on https://github.com/dotnet/runtime
if this is impacting your use case." text from all 6 HybridGlobalization
error messages.

Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
Changed "CompareOptions = {0} are not supported" to
"CompareOptions = {0} is not supported" since CompareOptions
is a singular entity being compared to a value.

Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
Reverted "is" back to "are" for CompareOptions messages since the
passed value can represent option(s) which can be plural.

Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
@matouskozak
matouskozak merged commit 11e43c9 into main Jan 5, 2026
142 of 145 checks passed
@matouskozak
matouskozak deleted the copilot/remove-hybrid-globalization-reference branch January 5, 2026 19:56
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.