[clr-interp] Fix abstract newobj test - #122624
#122624Merged
davidwrighton merged 1 commit intoDec 18, 2025
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_abstract_newobj_testdavidwrighton/runtime:fix_abstract_newobj_testCopy head branch name to clipboard
Merged
[clr-interp] Fix abstract newobj test#122624davidwrighton merged 1 commit intodotnet:maindotnet/runtime:mainfrom davidwrighton:fix_abstract_newobj_testdavidwrighton/runtime:fix_abstract_newobj_testCopy head branch name to clipboard
davidwrighton merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_abstract_newobj_testdavidwrighton/runtime:fix_abstract_newobj_testCopy head branch name to clipboard
Conversation
- Fix a test which should be throwing InvalidOperationException at call to newobj time, but calling into a JIT interface api just like the JIT Fixes Loader/classloader/generics/Instantiation/Negative/abstract01
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test failure in the interpreter by ensuring that attempting to instantiate an abstract class throws InvalidOperationException at the time of newobj, matching the JIT behavior.
Key Changes:
- Added a call to
getNewHelperAPI fornewobjoperations in the interpreter'sEmitCallmethod to trigger validation checks
3 tasks
BrzVlad
approved these changes
Dec 18, 2025
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Loader/classloader/generics/Instantiation/Negative/abstract01