Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix windows build - #122574

#122574
Merged
jkotas merged 4 commits into
dotnet:maindotnet/runtime:mainfrom
joanna-lee-0:fix-windows-buildCopy head branch name to clipboard
Dec 16, 2025
Merged

Fix windows build#122574
jkotas merged 4 commits into
dotnet:maindotnet/runtime:mainfrom
joanna-lee-0:fix-windows-buildCopy head branch name to clipboard

Conversation

@joanna-lee-0

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 16, 2025
@joanna-lee-0

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Dec 16, 2025
@jkotas jkotas added area-CodeGen-Interpreter-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 16, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. It matches what we are doing on Unix.

Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props Outdated
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Comment thread src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props Outdated
@jkotas
jkotas merged commit 139cc15 into dotnet:main Dec 16, 2025
130 of 133 checks passed
@joanna-lee-0
joanna-lee-0 deleted the fix-windows-build branch December 16, 2025 23:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-Interpreter-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.