[clr-interp] Adjust timeout on NativeRuntimeEventSourceTest - #122428
#122428Merged
davidwrighton merged 2 commits intoJan 6, 2026
dotnet:maindotnet/runtime:mainfrom
davidwrighton:interpreter-NativeRuntimeEventSourceTestdavidwrighton/runtime:interpreter-NativeRuntimeEventSourceTestCopy head branch name to clipboard
Merged
[clr-interp] Adjust timeout on NativeRuntimeEventSourceTest#122428davidwrighton merged 2 commits intodotnet:maindotnet/runtime:mainfrom davidwrighton:interpreter-NativeRuntimeEventSourceTestdavidwrighton/runtime:interpreter-NativeRuntimeEventSourceTestCopy head branch name to clipboard
davidwrighton merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
davidwrighton:interpreter-NativeRuntimeEventSourceTestdavidwrighton/runtime:interpreter-NativeRuntimeEventSourceTestCopy head branch name to clipboard
Conversation
The existing timeout of 5 seconds was too short. Make it 45 seconds.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
davidwrighton
enabled auto-merge (squash)
December 11, 2025 02:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the timeout for the NativeRuntimeEventSourceTest from 5 seconds to 45 seconds to address timeout issues on slower systems, particularly when running with the interpreter ([clr-interp]).
Key Changes
- Updated the while loop condition timeout from
TimeSpan.FromMinutes(1d / 12d)(5 seconds) toTimeSpan.FromMinutes(0.75)(45 seconds)
…est.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mdh1418
approved these changes
Jan 6, 2026
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing timeout of 5 seconds was too short. Make it 45 seconds.