Fix test script invocation of RunCrossGen2OnFiles - #122313
#122313Merged
elinor-fung merged 1 commit intoDec 9, 2025
dotnet:maindotnet/runtime:mainfrom
elinor-fung:fix-crossgen-test-scriptelinor-fung/runtime:fix-crossgen-test-scriptCopy head branch name to clipboard
Merged
Fix test script invocation of RunCrossGen2OnFiles#122313elinor-fung merged 1 commit intodotnet:maindotnet/runtime:mainfrom elinor-fung:fix-crossgen-test-scriptelinor-fung/runtime:fix-crossgen-test-scriptCopy head branch name to clipboard
elinor-fung merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:fix-crossgen-test-scriptelinor-fung/runtime:fix-crossgen-test-scriptCopy head branch name to clipboard
Conversation
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the CrossGen2 test script where the RunCrossgen2OnFiles function was being called with an incorrect number of parameters in non-composite build mode. The function expects 3 parameters (intermediate output file, final output file, and input files), but was only receiving 2, causing the input file to be misinterpreted as the final output file parameter.
- Corrects the invocation of
RunCrossgen2OnFilesto pass all 3 required parameters - Ensures consistency with the composite mode invocation pattern at line 180
hoyosjs
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122295