Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DiagnosticServer] Impove ipc message parsing resiliency #122257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdh1418 merged 4 commits into from
Dec 10, 2025
+5 −2
Merged

[DiagnosticServer] Impove ipc message parsing resiliency #122257

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d946efe
[IPCProtocol] Handle parsing truncated payloads
mdh1418 Dec 5, 2025
43fbcbd
[IPCProtocol] Prevent LoadProfiler read past buffer
mdh1418 Dec 6, 2025
93ea92f
[IPCProtocol] Enforce aligned wchar deserialization
mdh1418 Dec 6, 2025
5ffb2bf
Revert "[IPCProtocol] Enforce aligned wchar deserialization"
mdh1418 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "[IPCProtocol] Enforce aligned wchar deserialization" 
This reverts commit 93ea92f.
  • Loading branch information
@mdh1418
mdh1418 committed Dec 8, 2025
commit 5ffb2bfdd7837b67b0dfd12fd11cb983196decc7
2 changes: 0 additions & 2 deletions 2 src/native/eventpipe/ds-protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,6 @@ ipc_message_try_parse_string_utf16_t_byte_array (

bool result = false;

ep_raise_error_if_nok (((uintptr_t)*buffer & 0x1u) == 0);

ep_raise_error_if_nok (ds_ipc_message_try_parse_uint32_t (buffer, buffer_len, string_byte_array_len));
*string_byte_array_len *= sizeof (ep_char16_t);

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.