[clr-interp] Fix Double to ushort conversion - #120960
#120960Merged
davidwrighton merged 1 commit intoOct 22, 2025
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_double_to_ushort_castdavidwrighton/runtime:fix_double_to_ushort_castCopy head branch name to clipboard
Merged
[clr-interp] Fix Double to ushort conversion#120960davidwrighton merged 1 commit intodotnet:maindotnet/runtime:mainfrom davidwrighton:fix_double_to_ushort_castdavidwrighton/runtime:fix_double_to_ushort_castCopy head branch name to clipboard
davidwrighton merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
davidwrighton:fix_double_to_ushort_castdavidwrighton/runtime:fix_double_to_ushort_castCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type mismatch in the CLR interpreter's double-to-ushort conversion operation. The INTOP_CONV_U2_R8 instruction is intended to convert a double (R8 = 8-byte real) to an unsigned 16-bit integer (U2), but was incorrectly using float as the source type instead of double.
Key Changes:
- Corrected the template parameter in
ConvFpHelperfromfloattodoublefor the INTOP_CONV_U2_R8 case
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
davidwrighton
enabled auto-merge (squash)
October 21, 2025 23:34
janvorli
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.