[cDAC] fix extant APIs - #120948
#120948Merged
max-charlamb merged 1 commit intoOct 22, 2025
dotnet:maindotnet/runtime:mainfrom
max-charlamb:cdac-fix-extentsmax-charlamb/runtime:cdac-fix-extentsCopy head branch name to clipboard
Merged
[cDAC] fix extant APIs#120948max-charlamb merged 1 commit intodotnet:maindotnet/runtime:mainfrom max-charlamb:cdac-fix-extentsmax-charlamb/runtime:cdac-fix-extentsCopy head branch name to clipboard
max-charlamb merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
max-charlamb:cdac-fix-extentsmax-charlamb/runtime:cdac-fix-extentsCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in ClrDataModule.StartEnumExtents where multiple calls would not properly reset the handle, causing incorrect enumeration results. The fix involves correcting misplaced closing braces that were preventing the handle from being set properly.
Key Changes
- Corrected brace placement in
StartEnumExtentsto ensure the handle is always set after the lock scope ends - Added missing braces around debug assertions in
EnumExtentto properly scope conditional code
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
steveisok
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
StartEnumExtentswas called onClrDataModulemultiple times, thehandlewould not be reset so the results were incorrect.