Few interpreter EH fixes - #120684
#120684Merged
janvorli merged 3 commits intoOct 14, 2025
dotnet:maindotnet/runtime:mainfrom
janvorli:interpreter-eh-fixes-1janvorli/runtime:interpreter-eh-fixes-1Copy head branch name to clipboard
Merged
Few interpreter EH fixes#120684janvorli merged 3 commits intodotnet:maindotnet/runtime:mainfrom janvorli:interpreter-eh-fixes-1janvorli/runtime:interpreter-eh-fixes-1Copy head branch name to clipboard
janvorli merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
janvorli:interpreter-eh-fixes-1janvorli/runtime:interpreter-eh-fixes-1Copy head branch name to clipboard
Conversation
janvorli
commented
Oct 14, 2025
Member
- Correctly normalize objects that are not derived from Exception class before throwing them from the interpreter
- Ensure managed exceptions from QCALLs invoked by the interpreter are properly handled
- Add null check to INTOP_ZEROBLK_IMM
* Correctly normalize objects that are not derived from Exception class before throwing them from the interpreter * Ensure managed exceptions from QCALLs invoked by the interpreter are properly handled * Add null check to INTOP_ZEROBLK_IMM
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements several exception handling fixes for the interpreter in CoreCLR. The changes ensure proper normalization of thrown objects and improved handling of managed exceptions from native calls.
Key changes:
- Extracts duplicated exception normalization logic into a reusable
NormalizeThrownObjectfunction - Adds proper exception handling for QCALL invocations within the interpreter using PAL_TRY/PAL_EXCEPT
- Adds null pointer validation to the
INTOP_ZEROBLK_IMMinterpreter operation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/jithelpers.cpp | Refactors IL_Throw to use the new NormalizeThrownObject function, removing duplicate code |
| src/coreclr/vm/interpexec.cpp | Adds exception handling for unmanaged method transitions, null check for INTOP_ZEROBLK_IMM, and proper normalization for interpreter throws |
| src/coreclr/vm/exceptionhandling.h | Declares the new NormalizeThrownObject function |
| src/coreclr/vm/exceptionhandling.cpp | Implements the NormalizeThrownObject function with the extracted logic |
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
reviewed
Oct 14, 2025
kg
reviewed
Oct 14, 2025
kg
reviewed
Oct 14, 2025
kg
reviewed
Oct 14, 2025
kg
approved these changes
Oct 14, 2025
davidwrighton
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.