Add string.Contains shims for .NET Standard 2.0 - #119957
#119957Add string.Contains shims for .NET Standard 2.0#119957xtqqczze wants to merge 1 commit intodotnet:maindotnet/runtime:mainfrom xtqqczze:shim-stringcontainsxtqqczze/dotnet-runtime:shim-stringcontainsCopy head branch name to clipboard
string.Contains shims for .NET Standard 2.0#119957Conversation
bcdb52a to
02fca55
Compare
|
#119673 is also adding framework polyfills for new APIs. My preference would be to get that reviewed first, so that we can use a common switch of including such helper files in projects. I also had changes for Encoding and Span.Contains APIs sitting in a branch since they depend on the PR mentioned above being merged first:
|
8bdc636 to
a5fad42
Compare
|
@xtqqczze Do you think it's worth moving forward here given that MihaZupan@e819ccb already has a superset of these changes? |
I don't see |
* Use C# 14 extension members to polyfill the required APIs * Remove suppression of CA2249: Consider using 'string.Contains' instead of 'string.IndexOf'
a5fad42 to
10f8a7d
Compare
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Add C# 14 extension members to polyfill the following APIs:
Remove suppression of CA2249: Consider using 'string.Contains' instead of 'string.IndexOf'