Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/9.0-staging] [mono][debugger] Fix assertion when stepping - #118459

#118459
Merged
steveisok merged 3 commits into
release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
backport/pr-118458-to-release/9.0-stagingdotnet/runtime:backport/pr-118458-to-release/9.0-stagingCopy head branch name to clipboard
Sep 4, 2025
Merged

[release/9.0-staging] [mono][debugger] Fix assertion when stepping#118459
steveisok merged 3 commits into
release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
backport/pr-118458-to-release/9.0-stagingdotnet/runtime:backport/pr-118458-to-release/9.0-stagingCopy head branch name to clipboard

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Backport of #118458 to release/9.0-staging
Backport of #118459

/cc @thaystg

Customer Impact

This is a long standing debugger issue impacting MAUI customers that target iOS arm64. They experience a runtime crash after trying to step over from a previously hit breakpoint. We were incorrectly assuming the native offset from the breakpoint trampoline was always divisible by 4.

Customers could work around this by breaking somewhere else.

  • Customer reported
  • Found internally

dotnet/macios#18586
#110016

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Manually tested with the user sample.

Risk

Low risk, we copied the way that was done on amd64 to arm64.

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in 9.0.x

@BrzVlad

BrzVlad commented Aug 8, 2025

Copy link
Copy Markdown
Member

This triggered issues during macios bump. It will need follow up fix #118542

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 12, 2025
@leecow leecow modified the milestones: 9.0.x, 9.0.10 Aug 12, 2025
@steveisok
steveisok enabled auto-merge (squash) September 3, 2025 15:49
@steveisok

Copy link
Copy Markdown
Member

/ba-g Too generic of a timeout

@steveisok
steveisok merged commit 58cc46d into release/9.0-staging Sep 4, 2025
75 of 77 checks passed
@steveisok
steveisok deleted the backport/pr-118458-to-release/9.0-staging branch September 4, 2025 10:57
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.