[System.DirectoryServices] Fixed possible NRE in SAMStoreCtx.cs - #118123
#118123Merged
Merged
[System.DirectoryServices] Fixed possible NRE in SAMStoreCtx.cs#118123
Conversation
jeffhandley
approved these changes
Sep 1, 2025
jeffhandley
enabled auto-merge (squash)
September 1, 2025 22:08
auto-merge was automatically disabled
September 9, 2025 06:33
Head branch was pushed to by a user without write access
This was referenced Sep 9, 2025
Contributor
Author
|
@jeffhandley The trailing whitespace warning has been fixed. |
The principalSid may well have a null value if you create an instance of Principal without initializing _sid in it. The check at 652 confirms this.
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The principalSid may well have a null value if you create an instance of Principal without initializing _sid in it. The check at 652 confirms this.
Found by Linux Verification Center (linuxtesting.org) with SVACE.