[release/8.0-staging] Link peer's X509 stack handle to parent SSL safe handle - #115379
#115379Merged
jozkee merged 7 commits intoJun 10, 2025
release/8.0-stagingdotnet/runtime:release/8.0-stagingfrom
backport/pr-113124-to-release/8.0-stagingdotnet/runtime:backport/pr-113124-to-release/8.0-stagingCopy head branch name to clipboard
Merged
[release/8.0-staging] Link peer's X509 stack handle to parent SSL safe handle#115379jozkee merged 7 commits intorelease/8.0-stagingdotnet/runtime:release/8.0-stagingfrom backport/pr-113124-to-release/8.0-stagingdotnet/runtime:backport/pr-113124-to-release/8.0-stagingCopy head branch name to clipboard
jozkee merged 7 commits into
release/8.0-stagingdotnet/runtime:release/8.0-stagingfrom
backport/pr-113124-to-release/8.0-stagingdotnet/runtime:backport/pr-113124-to-release/8.0-stagingCopy head branch name to clipboard
Conversation
…aphy.Native/Interop.Ssl.cs Co-authored-by: Kevin Jones <vcsjones@github.com>
This was referenced May 7, 2025
This reverts commit 3cae60b.
karelz
approved these changes
May 28, 2025
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Member
|
Reliability problem (crash) reported by 2 customers (one of them on 8.0). Worth a fix. |
wfurt
approved these changes
Jun 4, 2025
wfurt
left a comment
Member
There was a problem hiding this comment.
LGTM. should we port the test as well for consistency?
bartonjs
approved these changes
Jun 4, 2025
bartonjs
left a comment
Member
There was a problem hiding this comment.
I agree with Tomas, seems like the test should have been included.
* Defer RemoteCertificate assignment after X509 Chain build * Add comment
* Fix SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE test failures * Fix build
* [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix Fixes #113833 * fixup! [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix Fixes #113833 * fixup! fixup! [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix Fixes #113833 * Update src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamDisposeTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
The test in the original PR was flaky and uncovered other issues, so I had to include more PR (mostli test fixes). It should be good now. |
3 tasks
Member
|
@rzikm reminder: servicing code complete for 8.0.18 is today @ 3PM PST. This is still missing tactics approval. |
Member
|
Approved via email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #113124 to release/8.0-staging
Fixes #109689
/cc @rzikm
Customer Impact
Reported by 2 customers. They experience process crashes when using specific pattern with short HTTP request timeout.
The crash happens when they dispose
SslStreamconcurrently with an ongoing handshake operation on Linux. The concurrent dispose may occur when usingHttpClientwith very short timeout settings.Regression
No -- the scenario is not too common and the timing in TLS 1.3 might be different from previous TLS versions, affecting chances of the problem happening.
Testing
Successfully reproduced on main with modified Runtime (artificial sleeps in code to increase likelihood of the race condition).
We lost customer repro environment after they updated OS and OpenSSL versions - we cannot validate on their side.
Risk
Low. The change is well contained and uses existing patterns.