[release/9.0-staging] Fix calling convention mismatch in GC callouts - #111105
#111105Merged
jeffschwMSFT merged 3 commits intoJan 8, 2025
release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
backport/pr-110685-to-release/9.0-stagingdotnet/runtime:backport/pr-110685-to-release/9.0-stagingCopy head branch name to clipboard
Merged
[release/9.0-staging] Fix calling convention mismatch in GC callouts#111105jeffschwMSFT merged 3 commits intorelease/9.0-stagingdotnet/runtime:release/9.0-stagingfrom backport/pr-110685-to-release/9.0-stagingdotnet/runtime:backport/pr-110685-to-release/9.0-stagingCopy head branch name to clipboard
jeffschwMSFT merged 3 commits into
release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
backport/pr-110685-to-release/9.0-stagingdotnet/runtime:backport/pr-110685-to-release/9.0-stagingCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
AaronRobinsonMSFT
approved these changes
Jan 6, 2025
jkotas
approved these changes
Jan 6, 2025
jeffschwMSFT
approved these changes
Jan 6, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110685 to release/9.0-staging
/cc @AaronRobinsonMSFT @MichalStrehovsky
Customer Impact
The GC will crash in .NET 9 when published with native AOT on win-x86. A GC callback was defined with an incorrect calling convention. This was reported by a customer - #110607.
Related servicing issue: #110815
Regression
Support for x86_32 was introduced in .NET 9.
Testing
Validated this with the help of Windows Store owners.
Risk
Low