Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/9.0-staging] Suppress IL3050 warnings in ILLink tests - #110340

#110340
Merged
sbomer merged 1 commit into
dotnet:release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
sbomer:net90ILLinkTestssbomer/runtime:net90ILLinkTestsCopy head branch name to clipboard
Dec 3, 2024
Merged

[release/9.0-staging] Suppress IL3050 warnings in ILLink tests#110340
sbomer merged 1 commit into
dotnet:release/9.0-stagingdotnet/runtime:release/9.0-stagingfrom
sbomer:net90ILLinkTestssbomer/runtime:net90ILLinkTestsCopy head branch name to clipboard

Conversation

@sbomer

@sbomer sbomer commented Dec 2, 2024

Copy link
Copy Markdown
Member

The ILLink Roslyn analyzer tests have been broken in release/9.0-staging since #108482.

This was fixed in main with f94b112, so backporting that fix to .NET 9 (this is a test-only change). #108757 (comment) has context on why this was failing.

@sbomer
sbomer requested review from a team, MichalStrehovsky and carlossanlop December 2, 2024 23:54
@sbomer
sbomer requested a review from marek-safar as a code owner December 2, 2024 23:54
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 2, 2024
@dotnet-policy-service dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label Dec 2, 2024
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 3, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode. Approved.
LGTM assuming CI is green.

@sbomer
sbomer merged commit 87916ee into dotnet:release/9.0-staging Dec 3, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 3, 2025
@sbomer
sbomer deleted the net90ILLinkTests branch June 26, 2026 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.