[cdac] Implement ISOSDacInterface::GetModule and IXCLRDataModule::GetFileName - #109133
#109133Merged
elinor-fung merged 15 commits intoOct 24, 2024
dotnet:maindotnet/runtime:mainfrom
elinor-fung:cdac-xclrmodule-filenameelinor-fung/runtime:cdac-xclrmodule-filenameCopy head branch name to clipboard
Merged
[cdac] Implement ISOSDacInterface::GetModule and IXCLRDataModule::GetFileName#109133elinor-fung merged 15 commits intodotnet:maindotnet/runtime:mainfrom elinor-fung:cdac-xclrmodule-filenameelinor-fung/runtime:cdac-xclrmodule-filenameCopy head branch name to clipboard
ISOSDacInterface::GetModule and IXCLRDataModule::GetFileName#109133elinor-fung merged 15 commits into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:cdac-xclrmodule-filenameelinor-fung/runtime:cdac-xclrmodule-filenameCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @tommcdon |
elinor-fung
commented
Oct 22, 2024
This was referenced Oct 23, 2024
This was referenced Oct 23, 2024
lambdageek
reviewed
Oct 23, 2024
lambdageek
reviewed
Oct 23, 2024
lambdageek
approved these changes
Oct 23, 2024
3 tasks
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClrDataModuleto cDAC as its implementation ofIXCLRDataModuleandIXCLRDataModule2GetFileNameICustomQueryInterfaceto handle QI-ing the legacy DAC forIMetaDataImportISOSDacInterface::GetModuleClrDataModuleModuleGetFileNametoLoadercontractIXClrDataModule::GetFileNameContributes to #99302, #108553
cc @AaronRobinsonMSFT @davidwrighton