Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/9.0] [aot] mono_aot_split_options: reset state after a backslash - #108212

#108212
Merged
jeffschwMSFT merged 2 commits into
release/9.0dotnet/runtime:release/9.0from
backport/pr-108067-to-release/9.0dotnet/runtime:backport/pr-108067-to-release/9.0Copy head branch name to clipboard
Oct 3, 2024
Merged

[release/9.0] [aot] mono_aot_split_options: reset state after a backslash#108212
jeffschwMSFT merged 2 commits into
release/9.0dotnet/runtime:release/9.0from
backport/pr-108067-to-release/9.0dotnet/runtime:backport/pr-108067-to-release/9.0Copy head branch name to clipboard

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Backport of #108067 to release/9.0

/cc @lambdageek

Customer Impact

  • Customer reported
  • Found internally

Customers targeting WebAssembly, Android or iOS with projects in a directory containing a " may run into crashes or errors during AOT compilation.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Manual testing

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Sep 24, 2024
@lambdageek lambdageek added this to the 9.0.0 milestone Sep 24, 2024

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 9 GA

@lambdageek lambdageek self-assigned this Sep 24, 2024
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Codegen-AOT-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.