Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Provide System.CodeDom package readme - #107372

#107372
Merged
buyaa-n merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
eNeRGy164:system-codedomeNeRGy164/dotnet-runtime:system-codedomCopy head branch name to clipboard
Sep 11, 2024
Merged

Provide System.CodeDom package readme#107372
buyaa-n merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
eNeRGy164:system-codedomeNeRGy164/dotnet-runtime:system-codedomCopy head branch name to clipboard

Conversation

@eNeRGy164

Copy link
Copy Markdown
Contributor

Fill out details for the System.CodeDom NuGet package readme.

See #99358

@ghost ghost added the area-System.CodeDom label Sep 4, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Sep 4, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-codedom
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis

Copy link
Copy Markdown
Contributor

Should it say that CodeDom is superseded by Roslyn?

@steveharter

Copy link
Copy Markdown
Contributor

Should it say that CodeDom is superseded by Roslyn?

I think it would good to mentioned that for new work, Roslyn should be used (in general, if you don't need CodeDom-specific functionality). Also, we have the readme.md file -- perhaps that would be a better place or an additional place for that statement.

Comment thread src/libraries/System.CodeDom/src/PACKAGE.md
@buyaa-n

buyaa-n commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

The changes looks good once the feedback about Roslyn is resolved

@eNeRGy164
eNeRGy164 requested a review from buyaa-n September 11, 2024 07:50
Comment thread src/libraries/System.CodeDom/src/PACKAGE.md Outdated

@buyaa-n buyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks you!

@buyaa-n
buyaa-n merged commit c381595 into dotnet:main Sep 11, 2024
@eNeRGy164
eNeRGy164 deleted the system-codedom branch September 11, 2024 20:25
buyaa-n added a commit to buyaa-n/runtime that referenced this pull request Sep 11, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
carlossanlop pushed a commit that referenced this pull request Sep 12, 2024
* Provide System.Composition package readme (#106443)

* Provide System.Composition package readme

* Fix empty lines

* Provide System.Composition.AttributedModel package readme (#106781)

* Provide System.Composition.AttributedModel package readme

* Improve after feedback

* Set correct PackageDescription

* Provide System.Composition.Convention package readme (#106782)

* Provide System.Composition.Convention package readme

* Improve after feedback

* Provide System.Composition.Hosting package readme (#106783)

* Provide System.Composition.Hosting package readme

* Improve after feedback

* Provide System.Composition.Runtime package readme (#106784)

* Provide System.Composition.Runtime package readme

* Improve after feedback

* Provide System.Composition.TypedParts package readme (#106785)

* Provide System.Composition.TypedParts package readme

* Improve after feedback

* Provide System.CodeDom package readme (#107372)

* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>

---------

Co-authored-by: Michaël Hompus <michael@hompus.nl>
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.CodeDom community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.