Check CancellationToken before TimeSpan in TimeProviderTaskExtensions - #107009
#107009Merged
tarekgh merged 3 commits intoSep 5, 2024
dotnet:maindotnet/runtime:mainfrom
brantburnett:time-provider-delaybrantburnett/runtime:time-provider-delayCopy head branch name to clipboard
Merged
Check CancellationToken before TimeSpan in TimeProviderTaskExtensions#107009tarekgh merged 3 commits intodotnet:maindotnet/runtime:mainfrom brantburnett:time-provider-delaybrantburnett/runtime:time-provider-delayCopy head branch name to clipboard
tarekgh merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
brantburnett:time-provider-delaybrantburnett/runtime:time-provider-delayCopy head branch name to clipboard
Conversation
…sions This makes the down-level behavior for Delay and WaitAsync match the behavior in .NET 8 and later, prefering to return a Canceled task over a Completed task or TimeoutException when the TimeSpan is Zero and the CancellationToken is already Canceled. Fixes dotnet#106996
Open
3 tasks
tarekgh
reviewed
Sep 4, 2024
tarekgh
reviewed
Sep 4, 2024
Member
|
CC @stephentoub |
stephentoub
approved these changes
Sep 5, 2024
Member
|
/ba-g the failing test looks infrastructure without any logs. |
Member
|
Thanks @brantburnett for your help with this change. |
Member
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10725729170 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…dotnet#107009) * Check CancellationToken before TimeSpan.Zero in TimeProviderTaskExtensions This makes the down-level behavior for Delay and WaitAsync match the behavior in .NET 8 and later, prefering to return a Canceled task over a Completed task or TimeoutException when the TimeSpan is Zero and the CancellationToken is already Canceled. Fixes dotnet#106996 * Test improvements based on feedback --------- Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…dotnet#107009) * Check CancellationToken before TimeSpan.Zero in TimeProviderTaskExtensions This makes the down-level behavior for Delay and WaitAsync match the behavior in .NET 8 and later, prefering to return a Canceled task over a Completed task or TimeoutException when the TimeSpan is Zero and the CancellationToken is already Canceled. Fixes dotnet#106996 * Test improvements based on feedback --------- Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the down-level behavior for Delay and WaitAsync match the behavior in .NET 8 and later, prefering to return a Canceled task over a Completed task or TimeoutException when the TimeSpan is Zero and the CancellationToken is already Canceled.
Fixes #106996