Add tests for assigning dataflow values to generic parameters through MakeGenericType - #106832
#106832Merged
jtschuster merged 6 commits intoJul 9, 2025
dotnet:maindotnet/runtime:mainfrom
jtschuster:RenameUnusedDiagnosticsjtschuster/runtime:RenameUnusedDiagnosticsCopy head branch name to clipboard
Merged
Add tests for assigning dataflow values to generic parameters through MakeGenericType#106832jtschuster merged 6 commits intodotnet:maindotnet/runtime:mainfrom jtschuster:RenameUnusedDiagnosticsjtschuster/runtime:RenameUnusedDiagnosticsCopy head branch name to clipboard
jtschuster merged 6 commits into
dotnet:maindotnet/runtime:mainfrom
jtschuster:RenameUnusedDiagnosticsjtschuster/runtime:RenameUnusedDiagnosticsCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
Member
|
@jtschuster is this good to merge? |
Member
Author
|
I think so. If CI looks good after the rebase it should be good to merge. |
jtschuster
enabled auto-merge (squash)
June 10, 2025 20:29
…ameUnusedDiagnostics
…nusedDiagnostics
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have any tests that exercise assigning values other than generic parameters or known types to generic parameters. For types that are actual System.Type objects, we need to use MakeGenericType/Method to raise these warnings. We also should add a public doc page for these warning codes (at least a few are missing).