Add new API docs for System.Runtime.InteropServices - #106208
#106208Merged
Merged
Add new API docs for System.Runtime.InteropServices#106208
Conversation
jkoritzinsky
requested review from
AaronRobinsonMSFT,
carlossanlop and
jtschuster
August 9, 2024 18:42
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
@jkoritzinsky Yes, they need them manually ported, because the source of truth is not triple slash comments, but dotnet-api-docs, as indicated by this turned-off property in the csproj: |
Contributor
|
Note: We can't just turn the property on, because we would need to backport the language-reviewed docs from dotnet-api-docs into runtime first. |
Member
Author
|
Okay I'll port the docs over manually after this PR gets in. |
carlossanlop
approved these changes
Aug 9, 2024
carlossanlop
left a comment
Contributor
There was a problem hiding this comment.
Left some suggestions for you to consider, and aside from that, it looks good.
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
This was referenced Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the rest of the missing API docs we can put in code from #105986
@carlossanlop the CollectionsMarshal APIs do have docs in source. Do we need to manually port them to dotnet-api-docs?