Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove unsafe modifier from Memory<T>.Span - #106085

#106085
Merged
tannergooding merged 6 commits into
dotnet:maindotnet/runtime:mainfrom
xtqqczze:MemoryUnsafeAddxtqqczze/dotnet-runtime:MemoryUnsafeAddCopy head branch name to clipboard
Nov 19, 2024
Merged

Remove unsafe modifier from Memory<T>.Span#106085
tannergooding merged 6 commits into
dotnet:maindotnet/runtime:mainfrom
xtqqczze:MemoryUnsafeAddxtqqczze/dotnet-runtime:MemoryUnsafeAddCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the area-System.Memory label Aug 7, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 7, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Comment thread src/libraries/System.Private.CoreLib/src/System/Memory.cs Outdated
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@MihuBot

Comment thread src/libraries/System.Private.CoreLib/src/System/Memory.cs Outdated
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@stephentoub I can't see how the build analysis failure is related.

@tannergooding
tannergooding merged commit 932da77 into dotnet:main Nov 19, 2024
@xtqqczze
xtqqczze deleted the MemoryUnsafeAdd branch November 19, 2024 19:57
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
* Remove `unsafe` modifier from `Memory<T>.Span`

* Make `desiredStartIndex` an `int`

* Use `nuint` and add comment

* fixup!b6b93d972b5b16b345e53c8c07c074cdc85cad9a

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Memory community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.