Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[RISC-V][LoongArch64] Pass FP struct fields at arbitrary offsets in ArgIterator and CallDescrWorker - #105800

#105800
Merged
jkotas merged 11 commits into
dotnet:maindotnet/runtime:mainfrom
tomeksowi:vm-empty-struct-passingtomeksowi/runtime:vm-empty-struct-passingCopy head branch name to clipboard
Aug 10, 2024
Merged

[RISC-V][LoongArch64] Pass FP struct fields at arbitrary offsets in ArgIterator and CallDescrWorker#105800
jkotas merged 11 commits into
dotnet:maindotnet/runtime:mainfrom
tomeksowi:vm-empty-struct-passingtomeksowi/runtime:vm-empty-struct-passingCopy head branch name to clipboard

Conversation

@tomeksowi

@tomeksowi tomeksowi commented Aug 1, 2024

Copy link
Copy Markdown
Member

Use new info calculated in #103945 on the VM side (shuffling thunks will be handled in a separate PR).

Stems from #101796, part of #84834, cc @dotnet/samsung @shushanhf @LuckyXu-HF

@ghost ghost added the area-ReadyToRun label Aug 1, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 1, 2024
tomeksowi
tomeksowi commented Aug 1, 2024
View reviewed changes
Comment thread src/coreclr/vm/loongarch64/calldescrworkerloongarch64.S

@tomeksowi tomeksowi Aug 1, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shushanhf @LuckyXu-HF PTAL, I don't really know LA asm and I had no way to test it..

@huoyaoyuan huoyaoyuan added arch-loongarch64 arch-riscv Related to the RISC-V architecture labels Aug 1, 2024
This was referenced Aug 1, 2024
Open
Closed
@tomeksowi

tomeksowi commented Aug 5, 2024

Copy link
Copy Markdown
Member Author

@MichalStrehovsky @jkotas can anyone review please?

@jkotas

jkotas commented Aug 5, 2024

Copy link
Copy Markdown
Member

@dotnet/samsung @shushanhf @LuckyXu-HF Could you please review and sign-off?

@dotnet-policy-service

dotnet-policy-service Bot commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

This was referenced Aug 8, 2024
Merged
Open
sirntar
sirntar approved these changes Aug 8, 2024
View reviewed changes

@sirntar sirntar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left review of the LA64 parts for @shushanhf and/or @LuckyXu-HF, but as for the RV64, everything looks good to me.

@tomeksowi I saw that the EmptyStructs test fails, but I'm not sure if this pr was supposed to solve this problem (?).

@shushanhf

shushanhf commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

OK, Thanks very much.
I will test it based on the latest patch right now.

shushanhf
shushanhf suggested changes Aug 9, 2024
View reviewed changes
Comment thread src/coreclr/vm/callingconvention.h Outdated
shushanhf
shushanhf reviewed Aug 9, 2024
View reviewed changes
Comment thread src/coreclr/vm/loongarch64/calldescrworkerloongarch64.S Outdated
shushanhf
shushanhf reviewed Aug 9, 2024
View reviewed changes
Comment thread src/coreclr/vm/loongarch64/calldescrworkerloongarch64.S Outdated
@tomeksowi @shushanhf
LoongArch typos
3985f11 
Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn>
shushanhf
shushanhf approved these changes Aug 9, 2024
View reviewed changes

@shushanhf shushanhf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@tomeksowi

tomeksowi commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@tomeksowi I saw that the EmptyStructs test fails, but I'm not sure if this pr was supposed to solve this problem (?).

This PR no, but #106112 disables them where not supported.

@risc-vv

risc-vv commented Aug 9, 2024

Copy link
Copy Markdown
3985f11 is being scheduled for building and testing

GIT: 3985f11e825beafbc9fd591d97942c4d69753333
REPO: dotnet/runtime
BRANCH: main

@risc-vv

risc-vv commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown
88815d2 is being scheduled for building and testing

GIT: 88815d2db74d1ac9039fe09874b81af9cdd9e47b
REPO: dotnet/runtime
BRANCH: main

Details

Release-build FAILED

buildinfo.json
${{details}}

@jkotas
jkotas merged commit 46c0166 into dotnet:main Aug 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes
@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner
+2 more reviewers
@shushanhf shushanhf shushanhf approved these changes
@sirntar sirntar sirntar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tomeksowi tomeksowi

Labels

arch-loongarch64 arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tomeksowi @jkotas @shushanhf @risc-vv @sirntar @huoyaoyuan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.