Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rename cdac_offsets to cdac_data - #105657

#105657
Merged
elinor-fung merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:rename-cdac-offsetselinor-fung/runtime:rename-cdac-offsetsCopy head branch name to clipboard
Jul 30, 2024
Merged

Rename cdac_offsets to cdac_data#105657
elinor-fung merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:rename-cdac-offsetselinor-fung/runtime:rename-cdac-offsetsCopy head branch name to clipboard

Conversation

@elinor-fung

Copy link
Copy Markdown
Member

The struct is used for exposing more than just offsets to the cDAC. Follow-up for #105534 (comment)

cc @jkoritzinsky

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM

Comment thread src/coreclr/vm/cdacdata.h Outdated
Comment thread src/coreclr/vm/cdacdata.h Outdated
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
@elinor-fung
elinor-fung merged commit 18eba09 into dotnet:main Jul 30, 2024
@elinor-fung
elinor-fung deleted the rename-cdac-offsets branch July 30, 2024 02:34
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.