Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default - #104202
#104202Merged
stephentoub merged 5 commits intoJul 2, 2024
dotnet:maindotnet/runtime:mainfrom
stephentoub:equalitycomparerdefaultalternatestephentoub/runtime:equalitycomparerdefaultalternateCopy head branch name to clipboard
Merged
Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default#104202stephentoub merged 5 commits intodotnet:maindotnet/runtime:mainfrom stephentoub:equalitycomparerdefaultalternatestephentoub/runtime:equalitycomparerdefaultalternateCopy head branch name to clipboard
IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default#104202stephentoub merged 5 commits into
dotnet:maindotnet/runtime:mainfrom
stephentoub:equalitycomparerdefaultalternatestephentoub/runtime:equalitycomparerdefaultalternateCopy head branch name to clipboard
Conversation
stephentoub
force-pushed
the
equalitycomparerdefaultalternate
branch
2 times, most recently
from
June 30, 2024 03:32
69a192b to
b627e2c
Compare
jkotas
reviewed
Jun 30, 2024
jkotas
reviewed
Jun 30, 2024
jkotas
reviewed
Jun 30, 2024
stephentoub
force-pushed
the
equalitycomparerdefaultalternate
branch
from
July 1, 2024 02:49
894ce80 to
a6e4488
Compare
… `EqualityComparer<string>.Default`
stephentoub
marked this pull request as ready for review
July 1, 2024 13:56
stephentoub
force-pushed
the
equalitycomparerdefaultalternate
branch
from
July 1, 2024 13:56
5b1ec8f to
d13131e
Compare
stephentoub
requested review from
MichalStrehovsky and
marek-safar
as code owners
July 1, 2024 13:56
eiriktsarpalis
left a comment
Member
There was a problem hiding this comment.
Seeing lots of build errors, but they appear to be infra related?
tannergooding
approved these changes
Jul 1, 2024
tannergooding
left a comment
Member
There was a problem hiding this comment.
Managed side changes LGTM.
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eiriktsarpalis
approved these changes
Jul 1, 2024
jkotas
approved these changes
Jul 1, 2024
jkotas
left a comment
Member
There was a problem hiding this comment.
LGTM (once the naot test run passed with no failures related to this change)
Member
|
Improvements: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102906