Fix flaky FSW test - #103873
#103873Conversation
|
BTW error case of too small InternalBufferSize is not being tested on non Windows (which may have different error behavior/limits) |
|
Comment says "where filePath is the path to changed file relative to the path passed into ReadDirectoryChanges." .. but the math does not use the relative path. Small beans; will cause over estimate, increasing events. |
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for providing the fix @danmoseley !
|
Can we run outer loop on this PR? It's just speculation that this will fix the test |
|
/azp list |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
#103753 also mentions |
|
Right, not really evidence that's related. Eg., it didn't start on the same day, it only happened once. |
|
OK, Build Analysis is recognizing all failures, so this is good to merge if you're OK with that @jozkee |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15537894547 |
Fix #103753
Test does not fail for me locally; making assumption that firing even more events will this will help avoid it failing elsewhere.