Make DAC return Module instead of PEAssembly for DacpModuleData::PEAssembly - #103821
#103821Merged
elinor-fung merged 1 commit intoJun 24, 2024
dotnet:maindotnet/runtime:mainfrom
elinor-fung:dac-hide-peassemblyelinor-fung/runtime:dac-hide-peassemblyCopy head branch name to clipboard
Merged
Make DAC return Module instead of PEAssembly for DacpModuleData::PEAssembly#103821elinor-fung merged 1 commit intodotnet:maindotnet/runtime:mainfrom elinor-fung:dac-hide-peassemblyelinor-fung/runtime:dac-hide-peassemblyCopy head branch name to clipboard
elinor-fung merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
elinor-fung:dac-hide-peassemblyelinor-fung/runtime:dac-hide-peassemblyCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @tommcdon |
lambdageek
approved these changes
Jun 21, 2024
Member
|
Could you please also make a matching change to SOS to stop printing PEAssembly so that it does not cause confusion? PEAssembly is not particular useful Module detail. It can be trivially fetched by regular windbg/lldb data inspection commands. |
jkotas
approved these changes
Jun 22, 2024
mikem8361
approved these changes
Jun 23, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid exposing
PEAssemblyin the DAC APIs. MakeDacpModuleData::PEAssemblyandDacpGetModuleData::PEAssemblybe theModuleinstead and update theGetPEFileNameandGetPEFileBaseto expect a module address.Contributes to #99302. We want to avoid exposing
PEAssemblyat all in the cDAC.