Add an IsKnownConstant path to SinCos - #103724
#103724Merged
Merged
Add an IsKnownConstant path to SinCos#103724
Conversation
tannergooding
force-pushed
the
sincos-fold
branch
from
June 19, 2024 19:59
1fc86b5 to
902c392
Compare
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
tannergooding
marked this pull request as ready for review
June 19, 2024 23:41
stephentoub
reviewed
Jun 20, 2024
stephentoub
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves some minor regressions that were found after switching to use SinCos