ARM64-SVE: GatherVectorWithByteOffsets - #103564
#103564ARM64-SVE: GatherVectorWithByteOffsets#103564kunalspathak merged 2 commits intodotnet:maindotnet/runtime:mainfrom a74nh:gatherload_byteoffsets_githuba74nh/runtime:gatherload_byteoffsets_githubCopy head branch name to clipboard
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
|
Stress results - failures looks like they are the usual stress predicate issue. |
|
Last of the gather loads. @dotnet/arm64-contrib @kunalspathak |
ebe9363 to
abaa66a
Compare
kunalspathak
left a comment
There was a problem hiding this comment.
Added few comments around testing.
| private void ValidateResult({Op1VectorType}<{Op1BaseType}> op1, {Op2BaseType}* op2, {Op3VectorType}<{Op3BaseType}> op3, void* result, [CallerMemberName] string method = "") | ||
| { | ||
| {Op1BaseType}[] inArray1 = new {Op1BaseType}[Op1ElementCount]; | ||
| byte[] inArray2 = new byte[Unsafe.SizeOf<{Op2BaseType}>() * Op2ElementCount]; |
There was a problem hiding this comment.
This template is identical to SveGatherVectorIndices.template except that byte[] vs. {Op2BaseType[]} and wondering if we add an argument like IndexType or something that is same as Op2BaseType for *Indices* and is byte for *Offset?
There was a problem hiding this comment.
Three differences between the two:
byte[]vs.{Op2BaseType[]}- In
ValidateResultfunctions, the byte array needs to be of sizeUnsafe.SizeOf<{Op2BaseType}>() * Op2ElementCountinstead ofOp2ElementCount. - The result is validated by using a helper function
Load{RetBaseType}FromByteArrayinstead of loading using array notationsecondOp[thirdOp[i]]
Agreed, the first one could be switched easily, but I think the second two would be confusing if generic.
|
/ba-g timeout issues |
This is a standard gatherload, but the offset is measured in bytes rather than the size of the vector. Therefore testing will have byte array, but needs to load a 32/64bit value.