Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Guard remaining IErrorInfo usage under FEATURE_COMINTEROP - #103510

#103510
Merged
AaronRobinsonMSFT merged 9 commits into
dotnet:maindotnet/runtime:mainfrom
huoyaoyuan:error-infohuoyaoyuan/runtime:error-infoCopy head branch name to clipboard
Jun 27, 2024
Merged

Guard remaining IErrorInfo usage under FEATURE_COMINTEROP#103510
AaronRobinsonMSFT merged 9 commits into
dotnet:maindotnet/runtime:mainfrom
huoyaoyuan:error-infohuoyaoyuan/runtime:error-infoCopy head branch name to clipboard

Conversation

@huoyaoyuan

Copy link
Copy Markdown
Member

The dummy definition in PAL can be removed now.

@huoyaoyuan
huoyaoyuan marked this pull request as ready for review June 15, 2024 08:51
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 15, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 15, 2024
@jkotas jkotas added area-Interop-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 15, 2024
Comment thread src/coreclr/inc/ex.h Outdated
Comment thread src/coreclr/inc/ex.h Outdated
Comment thread src/coreclr/inc/ex.h Outdated
Comment thread src/coreclr/inc/ex.h Outdated
Comment thread src/coreclr/inc/ex.h Outdated
Comment thread src/coreclr/vm/clrex.h Outdated
Comment thread src/coreclr/vm/clrex.h
Comment thread src/coreclr/vm/excep.cpp Outdated
Comment thread src/coreclr/vm/excep.h Outdated
Comment thread src/coreclr/vm/excep.h Outdated
huoyaoyuan and others added 2 commits June 24, 2024 12:58
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@huoyaoyuan

Copy link
Copy Markdown
Member Author

The remaining failure looks unrelated.

Comment thread src/coreclr/vm/excep.cpp Outdated
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 8511002 into dotnet:main Jun 27, 2024
@huoyaoyuan
huoyaoyuan deleted the error-info branch June 27, 2024 15:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.