Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert uses of Unsafe.BitCast with spans to unblock mono - #102998

#102998
Merged
jkotas merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
stephentoub:monobitcaststephentoub/runtime:monobitcastCopy head branch name to clipboard
Jun 3, 2024
Merged

Revert uses of Unsafe.BitCast with spans to unblock mono#102998
jkotas merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
stephentoub:monobitcaststephentoub/runtime:monobitcastCopy head branch name to clipboard

Conversation

@stephentoub

Copy link
Copy Markdown
Member

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 3, 2024
@jkotas

jkotas commented Jun 3, 2024

Copy link
Copy Markdown
Member

Could you please revert it in tests too?

   at System.Runtime.CompilerServices.UnsafeTests.BitCast() in /_/src/libraries/System.Runtime/tests/System.Runtime.CompilerServices.Unsafe.Tests/UnsafeTests.cs:line 1267
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)

@jkotas
jkotas merged commit c286a8e into dotnet:main Jun 3, 2024
lambdageek added a commit to lambdageek/runtime that referenced this pull request Jun 4, 2024
lambdageek added a commit that referenced this pull request Jun 9, 2024
…s up front (#103052)

* [interp] handle box + brtrue/brfalse pattern for byreflike types

   In cases where we don't do cprop and deadce (for example if `mono_interp_opt` is 0 because we're debugging) don't emit a box_vt opcode before a branch.  Instead just emit a constant true

   Fixes #102988

* Revert "Revert uses of Unsafe.BitCast with spans to unblock mono (#102998)"

   This reverts commit c286a8e.

   Reverts #102998

* remove the box byreflike retry code

   we handle box byreflike code patterns directly now

* handle box;isinst;{brtrue|brfalse|unbox.any} IL patterns

* Add test locking down mismatched box;isinst;unbox.any pattern

* remove the mismatch case in the interp.  throw IPE at execution time

* Update src/tests/Loader/classloader/generics/ByRefLike/Validate.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>

---------

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@stephentoub
stephentoub deleted the monobitcast branch June 18, 2024 17:43
stephentoub added a commit that referenced this pull request Jun 18, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.