Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move checked math helpers to C# - #102129

#102129
Merged
jkotas merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
jkotas:checked-math-helpersjkotas/runtime:checked-math-helpersCopy head branch name to clipboard
May 12, 2024
Merged

Move checked math helpers to C##102129
jkotas merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
jkotas:checked-math-helpersjkotas/runtime:checked-math-helpersCopy head branch name to clipboard

Conversation

@jkotas

@jkotas jkotas commented May 12, 2024

Copy link
Copy Markdown
Member
  • Eliminate a few more FCThrow
  • Take advantage of ConvertToNative to make helpers faster on current hardware

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Comment thread src/libraries/System.Private.CoreLib/src/System/Math.cs
Comment thread src/libraries/System.Private.CoreLib/src/System/Math.cs
@jkotas
jkotas force-pushed the checked-math-helpers branch from dfa72ea to 4a6ba3f Compare May 12, 2024 07:05
- Eliminate a few more FCThrow
- Take advantage of ConvertToNative to make helpers faster on current hardware
@jkotas
jkotas force-pushed the checked-math-helpers branch from 370663b to e376310 Compare May 12, 2024 14:46
Comment thread src/libraries/System.Private.CoreLib/src/System/Math.cs
Comment thread src/libraries/System.Private.CoreLib/src/System/Math.cs
@jkotas

jkotas commented May 12, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
jkotas marked this pull request as ready for review May 12, 2024 17:56
@jkotas
jkotas requested a review from MichalStrehovsky as a code owner May 12, 2024 17:56
@jkotas
jkotas merged commit 42c2362 into dotnet:main May 12, 2024
@jkotas
jkotas deleted the checked-math-helpers branch May 17, 2024 03:53
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Move checked math helpers to C#

- Eliminate a few more FCThrow
- Take advantage of ConvertToNative to make helpers faster on current hardware

* Use collection expressions in more places
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.