Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Target NetCoreAppToolCurrent in ILC test projects - #102058

#102058
Merged
MichalStrehovsky merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
PaulusParssinen:target-netcoreapptoolcurrent-in-ilc-testsPaulusParssinen/runtime:target-netcoreapptoolcurrent-in-ilc-testsCopy head branch name to clipboard
May 13, 2024
Merged

Target NetCoreAppToolCurrent in ILC test projects#102058
MichalStrehovsky merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
PaulusParssinen:target-netcoreapptoolcurrent-in-ilc-testsPaulusParssinen/runtime:target-netcoreapptoolcurrent-in-ilc-testsCopy head branch name to clipboard

Conversation

@PaulusParssinen

@PaulusParssinen PaulusParssinen commented May 9, 2024

Copy link
Copy Markdown
Contributor

Just testing if anything explodes if we target current .NET in these test projects. Came across these when hunting .NET Standard projects that pull in NativeFormatReader and stuff.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 9, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis Bot mentioned this pull request May 10, 2024
Closed
@MichalStrehovsky

MichalStrehovsky commented May 10, 2024

Copy link
Copy Markdown
Member

This looks good to me since the CI passed. But for posterity's sake, what problem does this solve?

@PaulusParssinen

PaulusParssinen commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

what problem does this solve?

Right. I often find myself going through Common code that is often untouched from its original CoreRT state where newer high-performance APIs such as BinaryPrimitives/BitOperations could be used. Partly out of curiosity, these two test projects surprised me as being NS2.0 targets, is there some background/history why theres a lot of ILC adjacent projects with NS2.0 targets where as majority of the tooling is latest .NET?

And whether stuff like this is still relevant?

runtime/src/coreclr/tools/Common/Internal/NativeFormat/NativeFormatReader.String.cs

Lines 53 to 59 in 56d7e5d

#if NETFX_45
byte[] bytes = new byte[numBytes];
for (int i = 0; i < bytes.Length; i++)
bytes[i] = *(_base + offset + i);
value = Encoding.UTF8.GetString(bytes, 0, bytes.Length);
#else

It's up to code owner to decide whether this is valuable at all, I don't feel strogly in either case 😅

@MichalStrehovsky
MichalStrehovsky merged commit 0e46919 into dotnet:main May 13, 2024
@PaulusParssinen
PaulusParssinen deleted the target-netcoreapptoolcurrent-in-ilc-tests branch May 13, 2024 13:04
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@PaulusParssinen @Ruihan-Yin
Target NetCoreAppToolCurrent in ILC test projects (dotnet#102058)
1935120
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

No one assigned

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulusParssinen @MichalStrehovsky
Morty Proxy This is a proxified and sanitized view of the page, visit original site.