Add the auto-created .mono/ folder to .gitignore - #101954
#101954Closed
carlossanlop wants to merge 1 commit into
Closed
Conversation
Contributor
|
Tagging subscribers to this area: @directhex |
jkoritzinsky
approved these changes
May 7, 2024
Contributor
Author
|
Looks like the CI is breaking, but I'm not yet sure if it's due to my change. |
Contributor
Author
|
I don't have a consistent repro to get the .mono/ folder created at the top level. Since this seems suspiciously related to the CI break, I'll close the PR and if I can get a consistent repro, I'll investigate why the folder is showing up. |
Member
|
I think the CI break is unrelated to this PR. I think it's related to my docker image changes (revert PR already open for that) |
Contributor
Author
|
Ah, okay, thanks for checking! I'll reopen after you merge your PR. |
Member
|
Can you approve the revert if you have a chance? |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed we don't have a
.mono/folder commited at the root of the repo, but it gets created sometimes when working with native code. I'm adding the entry to .gitignore ensures we don't accidentally get it included in a PR in the future.