Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add support for containing RotateLeft/RotateRight on Arm64 - #101030

#101030
Merged
tannergooding merged 5 commits into
dotnet:maindotnet/runtime:mainfrom
tannergooding:fix-101027tannergooding/runtime:fix-101027Copy head branch name to clipboard
Apr 15, 2024
Merged

Add support for containing RotateLeft/RotateRight on Arm64#101030
tannergooding merged 5 commits into
dotnet:maindotnet/runtime:mainfrom
tannergooding:fix-101027tannergooding/runtime:fix-101027Copy head branch name to clipboard

Conversation

@tannergooding

@tannergooding tannergooding commented Apr 14, 2024

Copy link
Copy Markdown
Member

This resolves #101027

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 14, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Apr 14, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
tannergooding marked this pull request as ready for review April 15, 2024 06:54
@tannergooding

tannergooding commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

Some decent diffs with no TP impact for the x ^ rotate(y, cns) pattern: https://dev.azure.com/dnceng-public/public/_build/results?buildId=643031&view=ms.vss-build-web.run-extensions-tab

-11,540 on Linux Arm64, with about 25% of that in PGO benchmarks

CC. @dotnet/jit-contrib, @EgorBo this should be ready for review.

EgorBo
EgorBo approved these changes Apr 15, 2024
View reviewed changes

@EgorBo EgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tannergooding

tannergooding commented Apr 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

hmmm, there is an SPMI replay failure. But it's in hwintrinsiccodegenarm64.cpp for DecodeFromUtf8 (which was updated over the weekend): #100589

I think it's likely unrelated to this PR, but I'll investigate and make sure an issue is opened before merging.

@tannergooding

tannergooding commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

Opened #101070, it is asserting without this PR and in other CI legs.

@tannergooding
tannergooding merged commit 3d0da2c into dotnet:main Apr 15, 2024
@tannergooding
tannergooding deleted the fix-101027 branch April 15, 2024 17:49
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@tannergooding @matouskozak
Add support for containing RotateLeft/RotateRight on Arm64 (dotnet#10…
bae5a06 
…1030)

* Add support for containing RotateLeft/RotateRight on Arm64

* Fix a variable name

* Applying formatting patch

* Ensure lsrabuild handles contained GT_ROR

* Ensure codegenlinear can consume contained GT_ROR
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@tannergooding tannergooding

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arm64: ror+eor -> eor, ror

2 participants

@tannergooding @EgorBo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.