Remove regex tests blocking on async calls - #100982
#100982Merged
buyaa-n merged 1 commit intoApr 17, 2024
dotnet:maindotnet/runtime:mainfrom
stephentoub:fixblockingregextestsstephentoub/runtime:fixblockingregextestsCopy head branch name to clipboard
Merged
Remove regex tests blocking on async calls#100982buyaa-n merged 1 commit intodotnet:maindotnet/runtime:mainfrom stephentoub:fixblockingregextestsstephentoub/runtime:fixblockingregextestsCopy head branch name to clipboard
buyaa-n merged 1 commit into
dotnet:maindotnet/runtime:mainfrom
stephentoub:fixblockingregextestsstephentoub/runtime:fixblockingregextestsCopy head branch name to clipboard
Conversation
It looks like these were written this way due to the limitation that spans can't be locals in an async method, even if the span doesn't live past an await. Address this for now by separating the code out into a local function.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
This was referenced Apr 12, 2024
buyaa-n
approved these changes
Apr 17, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
It looks like these were written this way due to the limitation that spans can't be locals in an async method, even if the span doesn't live past an await. Address this for now by separating the code out into a local function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #100715.
It looks like these were written this way due to the limitation that spans can't be locals in an async method, even if the span doesn't live past an await. Address this for now by separating the code out into a local function.