Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Removing RUC from Default and Ambient attributes - #100821

#100821
Merged
LakshanF merged 4 commits into
dotnet:maindotnet/runtime:mainfrom
LakshanF:DefaultValueFollowUpLakshanF/runtime:DefaultValueFollowUpCopy head branch name to clipboard
Apr 13, 2024
Merged

Removing RUC from Default and Ambient attributes#100821
LakshanF merged 4 commits into
dotnet:maindotnet/runtime:mainfrom
LakshanF:DefaultValueFollowUpLakshanF/runtime:DefaultValueFollowUpCopy head branch name to clipboard

Conversation

@LakshanF

@LakshanF LakshanF commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Missed removing the RUC when the feature switch is on with PR #100416

@LakshanF LakshanF self-assigned this Apr 9, 2024
@ghost

ghost commented Apr 9, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@LakshanF
LakshanF requested a review from sbomer April 9, 2024 15:22
@dotnet-policy-service

dotnet-policy-service Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 9, 2024
Closed
Closed
Closed
Closed
Closed
sbomer
sbomer reviewed Apr 9, 2024
View reviewed changes
Comment thread src/libraries/System.Private.CoreLib/src/System/ComponentModel/DefaultValueAttribute.cs Outdated
Comment thread src/libraries/System.Private.CoreLib/src/System/ComponentModel/DefaultValueAttribute.cs Outdated
sbomer
sbomer reviewed Apr 11, 2024
View reviewed changes
Comment thread src/libraries/System.Private.CoreLib/src/System/ComponentModel/DefaultValueAttribute.cs Outdated
This was referenced Apr 13, 2024
Closed
Closed
Closed
Closed
Closed
@LakshanF
LakshanF merged commit 715e697 into dotnet:main Apr 13, 2024
@LakshanF
LakshanF deleted the DefaultValueFollowUp branch April 13, 2024 17:11
@build-analysis build-analysis Bot mentioned this pull request Apr 13, 2024
Closed
@lewing lewing mentioned this pull request Apr 15, 2024
Merged
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@LakshanF @matouskozak
Removing RUC from Default and Ambient attributes (dotnet#100821)
897c5bd 
* Removing RUC from Default and Ambient attributes

* FB

* FB2
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomer sbomer sbomer approved these changes

Assignees

@LakshanF LakshanF

Labels

area-System.ComponentModel new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LakshanF @sbomer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.