[release/8.0-staging] Special casing System.Guid for COM VARIANT marshalling - #100734
#100734Closed
AaronRobinsonMSFT wants to merge 3 commits into
dotnet:release/8.0-stagingdotnet/runtime:release/8.0-stagingfrom
AaronRobinsonMSFT:port_100377AaronRobinsonMSFT/runtime:port_100377Copy head branch name to clipboard
Closed
[release/8.0-staging] Special casing System.Guid for COM VARIANT marshalling#100734AaronRobinsonMSFT wants to merge 3 commits intodotnet:release/8.0-stagingdotnet/runtime:release/8.0-stagingfrom AaronRobinsonMSFT:port_100377AaronRobinsonMSFT/runtime:port_100377Copy head branch name to clipboard
System.Guid for COM VARIANT marshalling#100734AaronRobinsonMSFT wants to merge 3 commits into
dotnet:release/8.0-stagingdotnet/runtime:release/8.0-stagingfrom
AaronRobinsonMSFT:port_100377AaronRobinsonMSFT/runtime:port_100377Copy head branch name to clipboard
Conversation
* Support System.Guid marshalling via VARIANT VARIANT marshalling in .NET 5+ requires a TLB for COM records (i.e., ValueType instances). This means that without a runtime provided TLB, users must define their own TLB for runtime types or define their own transfer types. We address this here by deferring to the NetFX mscorlib's TLB. Co-authored-by: Elinor Fung <elfung@microsoft.com>
System.Guid for COM VARIANT marshalling (#100377)System.Guid for COM VARIANT marshalling
This was referenced Apr 7, 2024
3 tasks
elinor-fung
approved these changes
Apr 9, 2024
Member
|
This change should be treated as a backport of a new feature. As a rule, we do not backport new features, backporting features requires an exception. If the exception is granted for this backport, we should consider placing the backported feature under a switch that is not enabled by default. |
Contributor
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #100377 to release/8.0-staging
Customer Impact
VARIANT marshalling in .NET 5+ requires a TLB
for COM records (i.e., ValueType instances). This
means that without a runtime provided TLB, users
must define their own TLB for runtime types or
define their own transfer types.
We address this here by deferring to the NetFX
mscorlib's TLB.
Regression
This support has never been in .NET Core 3.1/.NET 5+. This is helping porting efforts from .NET Framework to .NET 5+.
Risk
Low, this is enabling a narrow feature that was present in .NET Framework.