Simplify jitconfigvalues.h - #100704
#100704Merged
BruceForstall merged 2 commits intoApr 9, 2024
dotnet:maindotnet/runtime:mainfrom
BruceForstall:SimplifyJitConfigValuesBruceForstall/runtime:SimplifyJitConfigValuesCopy head branch name to clipboard
Merged
Simplify jitconfigvalues.h#100704BruceForstall merged 2 commits intodotnet:maindotnet/runtime:mainfrom BruceForstall:SimplifyJitConfigValuesBruceForstall/runtime:SimplifyJitConfigValuesCopy head branch name to clipboard
BruceForstall merged 2 commits into
dotnet:maindotnet/runtime:mainfrom
BruceForstall:SimplifyJitConfigValuesBruceForstall/runtime:SimplifyJitConfigValuesCopy head branch name to clipboard
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
It's been confusing to know if a configuration switch is available in DEBUG or non-DEBUG (Release) builds because you need to figure out which `ifdef` section it is defined in. This simplifies it by eliminating `#ifdef DEBUG` in jitconfigvalues.h. Each config variable is explicitly using `CONFIG_...` for DEBUG or `RELEASE_CONFIG_...` for non-DEBUG builds. I reformatted some of the CONFIG definitions to put the comments before the CONFIG definition instead of on the same line, so they read better after jit-format processes them.
BruceForstall
force-pushed
the
SimplifyJitConfigValues
branch
from
April 5, 2024 20:08
6e636e9 to
ad378f4
Compare
Contributor
Author
|
@dotnet/jit-contrib PTAL |
Contributor
Author
|
No diffs of course |
jakobbotsch
approved these changes
Apr 6, 2024
jakobbotsch
left a comment
Member
There was a problem hiding this comment.
Nice, this looks much better.
I was surprised by how many configs we expose in release. Presumably a bunch of those weren't even intended to be exposed but just happened to be by accident of where they were placed.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Simplify jitconfigvalues.h It's been confusing to know if a configuration switch is available in DEBUG or non-DEBUG (Release) builds because you need to figure out which `ifdef` section it is defined in. This simplifies it by eliminating `#ifdef DEBUG` in jitconfigvalues.h. Each config variable is explicitly using `CONFIG_...` for DEBUG or `RELEASE_CONFIG_...` for non-DEBUG builds. I reformatted some of the CONFIG definitions to put the comments before the CONFIG definition instead of on the same line, so they read better after jit-format processes them. * Fix OPT_CONFIG defines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been confusing to know if a configuration switch is available in DEBUG or non-DEBUG (Release) builds because you need to figure out which
ifdefsection it is defined in.This simplifies it by eliminating
#ifdef DEBUGin jitconfigvalues.h. Each config variable is explicitly usingCONFIG_...for DEBUG orRELEASE_CONFIG_...for non-DEBUG builds.I reformatted some of the CONFIG definitions to put the comments before the CONFIG definition instead of on the same line, so they read better after jit-format processes them.