Fix Path.ChangeExtension behavior with empty extension (#100687) - #100691
#100691Closed
jasonleenaylor wants to merge 6 commits into
dotnet:maindotnet/runtime:mainfrom
jasonleenaylor:fix-changeextensionjasonleenaylor/runtime:fix-changeextensionCopy head branch name to clipboard
Closed
Fix Path.ChangeExtension behavior with empty extension (#100687)#100691jasonleenaylor wants to merge 6 commits intodotnet:maindotnet/runtime:mainfrom jasonleenaylor:fix-changeextensionjasonleenaylor/runtime:fix-changeextensionCopy head branch name to clipboard
jasonleenaylor wants to merge 6 commits into
dotnet:maindotnet/runtime:mainfrom
jasonleenaylor:fix-changeextensionjasonleenaylor/runtime:fix-changeextensionCopy head branch name to clipboard
Conversation
- When ChangeExtension is called with an empty string completely remove the extension instead of adding a '.'
Contributor
|
How long has it had the current behavior? Is this potentially going to break existing code (it might still be worth changing) |
Contributor
|
Oh, that discussion should probably be in the bug. I didn't see there was a bug. Can you put "Fixes #100687" at the top of the top comment here? That also causes the issue to be closed if and when we merge this. |
This was referenced Apr 5, 2024
jasonleenaylor
marked this pull request as ready for review
April 8, 2024 17:17
Author
|
@dotnet-policy-service agree company="SIL International" |
Member
|
Closing as per #100687 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.